fix: catch handles promise#1059
Merged
Belco90 merged 2 commits intotesting-library:mainfrom Sep 3, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 96.46% 96.47%
=======================================
Files 50 50
Lines 2687 2693 +6
Branches 1112 1116 +4
=======================================
+ Hits 2592 2598 +6
Misses 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puglyfe
changed the title
catch handles promise
Belco90
approved these changes
Sep 3, 2025
Member
Belco90
left a comment
Belco90
left a comment
There was a problem hiding this comment.
This is great, thanks for your contribution!
|
🎉 This PR is included in version 7.6.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
hasChainedThenwithhasChainedPromiseHandlerin theisPromiseHandledlogicI'm a bit curious if there's a reason why this pattern wasn't supported previously. I know it's possible to rewrite tests to use async matchers, but this seems like something that the plugin should allow. Let me know if there's something I'm not considering here...
edit: github cached the PR title from my previous contribution 🤔 not sure what happened there.
Context
closes #1058